fix: xfail uncertainty test instead of version pin#976
Open
AngeloDanducci wants to merge 1 commit intogenerative-computing:mainfrom
Open
fix: xfail uncertainty test instead of version pin#976AngeloDanducci wants to merge 1 commit intogenerative-computing:mainfrom
AngeloDanducci wants to merge 1 commit intogenerative-computing:mainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
markstur
approved these changes
Apr 30, 2026
Contributor
markstur
left a comment
markstur
left a comment
There was a problem hiding this comment.
LGTM
tested the xfail and eyeballed the revision reversion
planetf1
approved these changes
May 1, 2026
Contributor
planetf1
left a comment
planetf1
left a comment
There was a problem hiding this comment.
I think we should go with this as an immediate fix, but I think there should be an issue (or maybe it's a discussion? ) to track a better long term fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Instead of pinning the versioning for this, move to xfail which will let CI pass even if the HF intrinsics portion is updated while local snapshot is out of date.
We didn't see failures on
context-attributionbefore but while I was pinning I pinned both. Sans pinning I think it makes sense to leave out context-attribution and add it to the xfail later if we run into issues.Testing
Attribution