Skip to content

fix: xfail uncertainty test instead of version pin #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AngeloDanducci wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

fix: xfail uncertainty test instead of version pin #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/formatters/granite/test_intrinsics_formatters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def _resolve_yaml(self):
task="uncertainty",
# Granite 4.0 adapters not currently available
repo_id="ibm-granite/granitelib-core-r1.0",
revision="c9c189f5ad0b2890660397070613fda46d6ceb80",
),
# aLoRA adapter for this intrinsic not currently available
# YamlJsonCombo(
Expand Down Expand Up @@ -217,7 +216,6 @@ def _resolve_yaml(self):
inputs_file=_INPUT_JSON_DIR / "context-attribution.json",
task="context-attribution",
repo_id="ibm-granite/granitelib-core-r1.0",
revision="c9c189f5ad0b2890660397070613fda46d6ceb80",
),
# gpt-oss-20b intrinsics (canned output tests only, no inference)
YamlJsonCombo(
Expand Down Expand Up @@ -408,12 +406,19 @@ def test_read_yaml():
_CANNED_INPUT_EXPECTED_DIR = _TEST_DATA_DIR / "test_canned_input"


def test_canned_input(yaml_json_combo_no_alora):
def test_canned_input(yaml_json_combo_no_alora, request):
"""
Verify that a given combination of chat completion and rewriting config produces
the expected output
"""
cfg = yaml_json_combo_no_alora
if cfg.short_name == "uncertainty":
request.applymarker(
pytest.mark.xfail(
reason="uncertainty downloads io.yaml from a live HF repo"
"snapshot may be stale if the upstream repo is updated"
)
)
if cfg.arguments_file:
with open(cfg.arguments_file, encoding="utf8") as f:
transform_kwargs = json.load(f)
Expand Down
Loading