Skip to content

Rename filesystem StorageService copy to export and mark as READ operation#3555

Merged
006627 merged 3 commits intomasterfrom
eteixeira-dev-fixExport
Dec 2, 2025
Merged

Rename filesystem StorageService copy to export and mark as READ operation#3555
006627 merged 3 commits intomasterfrom
eteixeira-dev-fixExport

Conversation

@eduardojst10
Copy link
Copy Markdown
Contributor

  • clarify semantics between internal copy and external export operations, ensuring proper transaction logging in exportToPath methods:
  • rename copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource, boolean replaceExisting) to export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource, boolean replaceExisting) to clearly distinguish between internal data replication within storages and exporting data to the filesystem or external paths;
  • ensure that exportToPath method in ModelService delegate to this new export method;
  • ensure exportToPath is executed under mainModelService;

@eduardojst10 eduardojst10 requested a review from 006627 November 7, 2025 17:13
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2025
@dosubot
Copy link
Copy Markdown

dosubot Bot commented Nov 7, 2025

Related Documentation

Checked 5 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@dosubot dosubot Bot added the enhancement label Nov 7, 2025
public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check code style

public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException, AuthorizationDeniedException {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

public void copy(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException {
public void export(StorageService fromService, StoragePath fromStoragePath, Path toPath, String resource,
boolean replaceExisting) throws AlreadyExistsException, GenericException {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 28, 2025
@eduardojst10 eduardojst10 requested a review from 006627 November 28, 2025 16:37
@006627 006627 merged commit 8cccdd0 into master Dec 2, 2025
6 of 7 checks passed
@hmiguim hmiguim deleted the eteixeira-dev-fixExport branch December 9, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants