Test result-cache restore does not trigger reflection#5617
Merged
staabm merged 8 commits intophpstan:2.1.xfrom May 9, 2026
Merged
Test result-cache restore does not trigger reflection#5617staabm merged 8 commits intophpstan:2.1.xfrom
staabm merged 8 commits intophpstan:2.1.xfrom
Conversation
Co-Authored-By: Petr Morávek <petr@pada.cz>
staabm
changed the title
Contributor
Author
|
ok cool. the test fails before the phpstan-symfony fix and is green on the latest commit (fix) |
staabm
added a commit
that referenced
this pull request
May 9, 2026
Co-authored-by: Petr Morávek <petr@pada.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test is expected to fail until phpstan/phpstan-symfony#486 is merged.
after we proved this works like expected I would expand this test to include all 1st party phpstan extensions, so the test asserts, none of the 1st party extenions leads to reflection beeing triggered while result-cache restore.
e.g. we already know about the same problem in phpstan-doctrine