Skip to content

Refactoring SdlRouterService and SdlBroadcastReceiver#1352

Draft
RHenigan wants to merge 4 commits intodevelopfrom
feature/issue_349
Draft

Refactoring SdlRouterService and SdlBroadcastReceiver#1352
RHenigan wants to merge 4 commits intodevelopfrom
feature/issue_349

Conversation

@RHenigan
Copy link
Copy Markdown
Contributor

Fixes #349

This PR is [not ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Summary

This branch will deprecate SDLRouterService and SDLBroadcastReceiver and create BaseRouterService and BaseBroadcastReceiver which extend these deprecated classes. This is because there is a lot of confusion added by the creating a SDLRouterService class in the application which uses the same name as its parent class.

CLA

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2020

Codecov Report

❌ Patch coverage is 9.80392% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.67%. Comparing base (20d3344) to head (d4a5d0c).
⚠️ Report is 2042 commits behind head on develop.

Files with missing lines Patch % Lines
...icelink/transport/MultiplexBluetoothTransport.java 4.34% 22 Missing ⚠️
...martdevicelink/transport/SdlBroadcastReceiver.java 0.00% 7 Missing ⚠️
...artdevicelink/transport/MultiplexUsbTransport.java 0.00% 4 Missing ⚠️
...link/transport/USBAccessoryAttachmentActivity.java 0.00% 4 Missing ⚠️
...artdevicelink/transport/MultiplexTcpTransport.java 0.00% 2 Missing ⚠️
...com/smartdevicelink/transport/TransportBroker.java 0.00% 2 Missing ⚠️
...m/smartdevicelink/SdlConnection/SdlConnection.java 66.66% 1 Missing ⚠️
...artdevicelink/transport/BaseBroadcastReceiver.java 0.00% 1 Missing ⚠️
...rtdevicelink/transport/MultiplexBaseTransport.java 0.00% 1 Missing ⚠️
...rtdevicelink/transport/RouterServiceValidator.java 0.00% 1 Missing ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (9.80%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1352      +/-   ##
=============================================
- Coverage      47.67%   47.67%   -0.01%     
- Complexity      4432     4433       +1     
=============================================
  Files            489      491       +2     
  Lines          23848    23851       +3     
  Branches        2753     2753              
=============================================
+ Hits           11369    11370       +1     
- Misses         11778    11780       +2     
  Partials         701      701              
Files with missing lines Coverage Δ
...m/smartdevicelink/transport/BaseRouterService.java 100.00% <100.00%> (ø)
...om/smartdevicelink/transport/SdlRouterService.java 11.64% <ø> (ø)
...smartdevicelink/transport/TCPTransportManager.java 0.00% <ø> (ø)
...n/java/com/smartdevicelink/util/ServiceFinder.java 62.50% <100.00%> (ø)
...m/smartdevicelink/SdlConnection/SdlConnection.java 17.41% <66.66%> (ø)
...artdevicelink/transport/BaseBroadcastReceiver.java 0.00% <0.00%> (ø)
...rtdevicelink/transport/MultiplexBaseTransport.java 39.13% <0.00%> (ø)
...rtdevicelink/transport/RouterServiceValidator.java 52.60% <0.00%> (ø)
...tdevicelink/transport/SdlRouterStatusProvider.java 0.00% <0.00%> (ø)
...artdevicelink/transport/MultiplexTcpTransport.java 0.00% <0.00%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant