Skip to content

Refactoring SdlRouterService and SdlBroadcastReceiver #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RHenigan wants to merge 4 commits into
base: develop
Choose a base branch
from

Update SdlReceiver for basebroadcastreceiver

d4a5d0c
Select commit
Loading
Failed to load commit list.
Draft

Refactoring SdlRouterService and SdlBroadcastReceiver #1352

Update SdlReceiver for basebroadcastreceiver
d4a5d0c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2026 in 0s

47.67% (target 40.00%)

View this Pull Request on Codecov

47.67% (target 40.00%)

Details

Codecov Report

❌ Patch coverage is 9.80392% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.67%. Comparing base (20d3344) to head (d4a5d0c).
⚠️ Report is 2042 commits behind head on develop.

Files with missing lines Patch % Lines
...icelink/transport/MultiplexBluetoothTransport.java 4.34% 22 Missing ⚠️
...martdevicelink/transport/SdlBroadcastReceiver.java 0.00% 7 Missing ⚠️
...artdevicelink/transport/MultiplexUsbTransport.java 0.00% 4 Missing ⚠️
...link/transport/USBAccessoryAttachmentActivity.java 0.00% 4 Missing ⚠️
...artdevicelink/transport/MultiplexTcpTransport.java 0.00% 2 Missing ⚠️
...com/smartdevicelink/transport/TransportBroker.java 0.00% 2 Missing ⚠️
...m/smartdevicelink/SdlConnection/SdlConnection.java 66.66% 1 Missing ⚠️
...artdevicelink/transport/BaseBroadcastReceiver.java 0.00% 1 Missing ⚠️
...rtdevicelink/transport/MultiplexBaseTransport.java 0.00% 1 Missing ⚠️
...rtdevicelink/transport/RouterServiceValidator.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1352      +/-   ##
=============================================
- Coverage      47.67%   47.67%   -0.01%     
- Complexity      4432     4433       +1     
=============================================
  Files            489      491       +2     
  Lines          23848    23851       +3     
  Branches        2753     2753              
=============================================
+ Hits           11369    11370       +1     
- Misses         11778    11780       +2     
  Partials         701      701
Files with missing lines Coverage Δ
...m/smartdevicelink/transport/BaseRouterService.java 100.00% <100.00%> (ø)
...om/smartdevicelink/transport/SdlRouterService.java 11.64% <ø> (ø)
...smartdevicelink/transport/TCPTransportManager.java 0.00% <ø> (ø)
...n/java/com/smartdevicelink/util/ServiceFinder.java 62.50% <100.00%> (ø)
...m/smartdevicelink/SdlConnection/SdlConnection.java 17.41% <66.66%> (ø)
...artdevicelink/transport/BaseBroadcastReceiver.java 0.00% <0.00%> (ø)
...rtdevicelink/transport/MultiplexBaseTransport.java 39.13% <0.00%> (ø)
...rtdevicelink/transport/RouterServiceValidator.java 52.60% <0.00%> (ø)
...tdevicelink/transport/SdlRouterStatusProvider.java 0.00% <0.00%> (ø)
...artdevicelink/transport/MultiplexTcpTransport.java 0.00% <0.00%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov