Skip to content

Don't use auto-inferred name in as.data.table.matrix under new rule#7149

Merged
tdhock merged 3 commits intomasterfrom
as-dt-matrix-v1
Jul 9, 2025
Merged

Don't use auto-inferred name in as.data.table.matrix under new rule#7149
tdhock merged 3 commits intomasterfrom
as-dt-matrix-v1

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

For #7145. This probably doesn't fix everything; I've only checked on {tidytable}.

@MichaelChirico MichaelChirico requested a review from jangorecki July 8, 2025 23:19
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (4cf9a70) to head (1acf5da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7149   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          81       81           
  Lines       15017    15019    +2     
=======================================
+ Hits        14793    14795    +2     
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 8, 2025

No obvious timing issues in HEAD=as-dt-matrix-v1
Comparison Plot

Generated via commit 1acf5da

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 42 seconds
Installing different package versions 9 minutes and 5 seconds
Running and plotting the test cases 2 minutes and 26 seconds

@tdhock
Copy link
Copy Markdown
Member

tdhock commented Jul 9, 2025

great, thanks, let's see how this works.

@tdhock tdhock merged commit 8b1e3f9 into master Jul 9, 2025
12 checks passed
@MichaelChirico MichaelChirico deleted the as-dt-matrix-v1 branch July 9, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants