Skip to content

Add an option for enabling new data.table(<1-column matrix>) auto-naming behavior#7158

Merged
MichaelChirico merged 14 commits intomasterfrom
dt-mat-opt
Jul 15, 2025
Merged

Add an option for enabling new data.table(<1-column matrix>) auto-naming behavior#7158
MichaelChirico merged 14 commits intomasterfrom
dt-mat-opt

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

@MichaelChirico MichaelChirico commented Jul 11, 2025

Follow-up to #7149 for #7145. Confirmed all of {dtts}, {latrend}, {vardpoor} pass R CMD check under this branch.

Closes #7159; Closes #3193

NB: this has a conflict with #7156.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 11, 2025

  • HEAD=dt-mat-opt slower P<0.001 for isoweek improved in #7144
    Comparison Plot

Generated via commit 33f5ec0

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 41 seconds
Installing different package versions 40 seconds
Running and plotting the test cases 2 minutes and 34 seconds

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (67670e9) to head (33f5ec0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7158   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15185    15185           
=======================================
  Hits        14999    14999           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelChirico MichaelChirico merged commit 2675539 into master Jul 15, 2025
12 checks passed
@MichaelChirico MichaelChirico deleted the dt-mat-opt branch July 15, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0-column matrix results in 0-row table in data.table() data.table(vector, matrix) can return duplicate column names

2 participants