Avoid eval(parse(...)) internally#7156
Merged
MichaelChirico merged 10 commits intomasterfrom Jul 15, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7156 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 81 81
Lines 15185 15187 +2
=======================================
+ Hits 14999 15001 +2
Misses 186 186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 80f788f Download link for the artifact containing the test results: ↓ atime-results.zip
|
aitap
reviewed
Jul 11, 2025
Member
Author
|
This also fixes a 10-year-old mistake in fd37731 -- |
aitap
approved these changes
Jul 15, 2025
Member
aitap
left a comment
There was a problem hiding this comment.
Thanks! A fine way to rewrite the function. I was going to suggest regmatches, but this is simple enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

eval(parse())in a loop callingoptions()many time is replaced by a single call tooptions()withouteval(parse()).Also tuck in a style & a tiny performance improvement to
.checkTypos().