Adopt params and sig from other when merging a Method with no sig#585
Merged
Adopt params and sig from other when merging a Method with no sig#585
params and sig from other when merging a Method with no sig#585Conversation
KaanOzkan
commented
Apr 9, 2026
| assert_equal(<<~RBI, res.string) | ||
| class Foo | ||
| sig { params(_expand: T.nilable(T::Array[String])).returns(T.nilable(T::Array[String])) } | ||
| def expand=(_expand); end |
Contributor
Author
There was a problem hiding this comment.
Before this change we'd have def expand=(value); end instead.
amomchilov
approved these changes
Apr 10, 2026
paracycle
approved these changes
Apr 10, 2026
Member
paracycle
left a comment
paracycle
left a comment
There was a problem hiding this comment.
Thanks for the fix, and sorry I missed this in the first place.
KaanOzkan
force-pushed
the
ko-fix-sig-param-mismatch
branch
from
db3379b to
d9e7b81
Compare
KaanOzkan
force-pushed
the
ko-fix-sig-param-mismatch
branch
from
d9e7b81 to
b5c95b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Shopify/tapioca#2589
When merging two method definitions where the left has no sig but the right does, adopt the right's param names alongside its sigs. Previously only the sigs were adopted, causing a mismatch between the method's param names and the sig's param names.