Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/rbi/rewriters/merge_trees.rb
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,12 @@ def merge_with(other)
super

# If self is the all-anonymous side (since compatible_with? ensures
# at most one side is), adopt other's non-anonymous param names and sigs.
if params.all?(&:anonymous?)
# at most one side is), or if self has no sigs but other does, adopt
# other's non-anonymous param names and sigs.
if params.all?(&:anonymous?) || (sigs.empty? && !other.sigs.empty?)
@params = other.params.dup
@sigs = other.sigs.dup unless other.sigs.empty?
return
end

other.sigs.each do |sig|
Expand Down
25 changes: 25 additions & 0 deletions test/rbi/rewriters/merge_trees_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1333,5 +1333,30 @@ def m2(_a); end
RBI
refute_empty(res.conflicts)
end

def test_merge_methods_without_sig_adopts_params_and_sig_from_other
tree1 = parse_rbi(<<~RBI)
class Foo
def expand=(value); end
end
RBI

tree2 = parse_rbi(<<~RBI)
class Foo
sig { params(_a_different_name: T.nilable(T::Array[String])).returns(T.nilable(T::Array[String])) }
def expand=(_a_different_name); end
end
RBI

res = tree1.merge(tree2)

assert_equal(<<~RBI, res.string)
class Foo
sig { params(_a_different_name: T.nilable(T::Array[String])).returns(T.nilable(T::Array[String])) }
def expand=(_a_different_name); end
end
RBI
assert_empty(res.conflicts)
end
end
end
Loading