chore(auth_origin_pulls_cert): add test cases for migration#6880
Closed
chore(auth_origin_pulls_cert): add test cases for migration#6880
Conversation
Contributor
Author
|
Closing in favor of #6887, which does all aop resources at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Add more test cases and get current migration tests to pass for
auth_origin_pulls_certificateAcceptance test run results
Steps to run acceptance tests
TF_ACC=1 TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate go test ./internal/services/authenticated_origin_pulls_certificate/migration/v500 -vTest output
Resource Tests
Migration Tests
=== RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5 --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone (47.09s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest (26.80s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5 (20.30s) === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal (40.38s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal (24.17s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal (16.21s) === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields (39.67s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields (21.77s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields (17.89s) PASS ok github.com/cloudflare/terraform-provider-cloudflare/internal/services/authenticated_origin_pulls_certificate/migration/v500 128.611sAdditional context & links