Skip to content

feat(aop): add state upgraders for aop resources#6887

Merged
ssicard merged 7 commits intonextfrom
ssicard/stateupgrader/auth_origin_pulls
Mar 9, 2026
Merged

feat(aop): add state upgraders for aop resources#6887
ssicard merged 7 commits intonextfrom
ssicard/stateupgrader/auth_origin_pulls

Conversation

@ssicard
Copy link
Copy Markdown
Contributor

@ssicard ssicard commented Mar 5, 2026

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Support state upgraders for resource authenticated_origin_pulls/ authenticated_origin_pulls_settings and authenticated_origin_pulls_certificate/ authenticated_origin_pulls_hostname_certificate

Acceptance test run results

  • I have added or updated acceptance tests for my changes
  • I have run acceptance tests for my changes and included the results below

Steps to run acceptance tests

# authenticated_origin_pulls
TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate TF_ACC=1 go test ./internal/services/authenticated_origin_pulls/migration/v500 -v -run TestMigrate

# authenticated_origin_pulls_settings
TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate TF_ACC=1 go test ./internal/services/authenticated_origin_pulls_settings/migration/v500 -v -run TestMigrate

# authenticated_origin_pulls_certificate
TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate TF_ACC=1 go test ./internal/services/authenticated_origin_pulls_certificate/migration/v500 -v

# authenticated_origin_pulls_hostname_certificate
TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate TF_ACC=1 go test ./internal/services/authenticated_origin_pulls_hostname_certificate/migration/v500 -v

Test output

authenticated_origin_pulls

=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic/from_v4_latest
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic/from_v5
--- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic (17.91s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic/from_v4_latest (14.32s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Basic/from_v5 (3.59s)
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled/from_v4_latest
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled/from_v5
--- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled (18.11s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled/from_v4_latest (12.96s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Disabled/from_v5 (5.14s)
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple/from_v4_latest
=== RUN   TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple/from_v5
--- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple (23.54s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple/from_v4_latest (19.21s)
    --- PASS: TestMigrateAuthenticatedOriginPulls_V4ToV5_Multiple/from_v5 (4.33s)
PASS

authenticated_origin_pulls_settings

=== RUN   TestMigrateAuthenticatedOriginPullsSettingsBasic
--- PASS: TestMigrateAuthenticatedOriginPullsSettingsBasic (2.31s)
=== RUN   TestMigrateAuthenticatedOriginPullsSettingsDisabled
--- PASS: TestMigrateAuthenticatedOriginPullsSettingsDisabled (2.74s)
=== RUN   TestMigrateAuthenticatedOriginPullsSettingsWithCertificateResource
--- PASS: TestMigrateAuthenticatedOriginPullsSettingsWithCertificateResource (3.07s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/services/authenticated_origin_pulls_settings/migration/v500	9.688s

authenticated_origin_pulls_certificate

=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5
--- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone (59.80s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest (23.85s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5 (35.96s)
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal
--- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal (59.34s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal (40.66s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal (18.67s)
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields
=== RUN   TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields
--- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields (61.56s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields (29.24s)
    --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields (32.32s)
=== RUN   TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5
--- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5 (30.16s)
=== RUN   TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5_Minimal
--- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5_Minimal (36.70s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/services/authenticated_origin_pulls_certificate/migration/v500	249.036s

authenticated_origin_pulls_hostname_certificate

=== RUN   TestMigrateAuthenticatedOriginPullsHostnameCertificateBasic
--- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificateBasic (3.16s)
=== RUN   TestMigrateAuthenticatedOriginPullsHostnameCertificateMinimal
--- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificateMinimal (2.67s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/services/authenticated_origin_pulls_hostname_certificate/migration/v500	7.222s

Additional context & links

@ssicard ssicard self-assigned this Mar 5, 2026
@ssicard ssicard changed the title Ssicard/stateupgrader/auth origin pulls chore(aop): add state upgraders for aop resources Mar 9, 2026
@ssicard ssicard marked this pull request as ready for review March 9, 2026 17:12
@ssicard ssicard requested a review from a team as a code owner March 9, 2026 17:12
@vaishakdinesh vaishakdinesh changed the title chore(aop): add state upgraders for aop resources feat(aop): add state upgraders for aop resources Mar 9, 2026
@vaishakdinesh
Copy link
Copy Markdown
Member

I think need to bump the schema versions for the other 2 resources too yeah?

@ssicard ssicard merged commit c819e8a into next Mar 9, 2026
4 checks passed
@ssicard ssicard deleted the ssicard/stateupgrader/auth_origin_pulls branch March 9, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants