bake: support null arg and label value#1449
Merged
tonistiigi merged 2 commits intodocker:masterfrom Dec 15, 2022
Merged
Conversation
Member
Author
|
Including a null value in a string template is not yet supported: variable "GO_VERSION" {
default = null
}
target "default" {
args = {
GO_VERSION = "${GO_VERSION}-alpine"
}
}This will lead to: We could convert to the expected type. |
crazy-max
commented
Dec 3, 2022
0e86cf9 to
528b1be
Compare
528b1be to
0e0dd0f
Compare
deac246 to
2ad47c0
Compare
0eadb81 to
3ba3dc2
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3ba3dc2 to
fe76a1b
Compare
tonistiigi
approved these changes
Dec 15, 2022
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #1362 (comment)
In this example,
GO_VERSIONarg will always be sent in the request and overwrites the one in the Dockerfile. Therefore build would fail asGO_VERSIONwill be empty.With this PR,
nulltype is now handled and will set the arg only if set:Signed-off-by: CrazyMax crazy-max@users.noreply.github.com