Skip to content

Fix github builder#19

Merged
AlexVCaron merged 56 commits intoscilus:mainfrom
AlexVCaron:feat/github_worker_fork
Jun 24, 2023
Merged

Fix github builder#19
AlexVCaron merged 56 commits intoscilus:mainfrom
AlexVCaron:feat/github_worker_fork

Conversation

@AlexVCaron
Copy link
Copy Markdown
Collaborator

  • Fixed locales generation in build system
  • Fixed CRLF line endings invalidating cache using .gitattributes
    • When the repository is checked out on some platforms, files in the build systems get converted from LF to CRLF
    • The build is then run with CRLF endings, files content is hashed with those endings to create cache entries
    • On platforms checking out the system with LF endings, the cache misses because the hash with LF endings is different
  • Fix github builder's targeted repositories (github and dockerhub) when on a fork
    • Fetch the fork container-scilus github repository instead of scilus using the owner defined in the github context
    • In addition to scilus, fetch cache from dockerhub repository defined by the fork's secrets
  • Update dockerfile definition to 1.5.0, buildkit to 0.11 and buildx to 0.10

Cache mechanisms are in test, WIP status will be removed once local builders and github builders are all stable.

@AlexVCaron AlexVCaron force-pushed the feat/github_worker_fork branch from cfaa51c to d390ad1 Compare June 15, 2023 20:31
@AlexVCaron AlexVCaron changed the title [WIP] Fix github builder Fix github builder Jun 24, 2023
@AlexVCaron AlexVCaron merged commit 8256ff7 into scilus:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant