fixes(configuration): Not unique exporter for exporter type #1796
Merged
AndreyAkinshin merged 8 commits intodotnet:masterfrom Feb 16, 2022
Merged
fixes(configuration): Not unique exporter for exporter type #1796AndreyAkinshin merged 8 commits intodotnet:masterfrom
AndreyAkinshin merged 8 commits intodotnet:masterfrom
Conversation
workgroupengineering
force-pushed
the
Bugfix/Issue_1700_V2
branch
from
dbf79fa to
da38535
Compare
AndreyAkinshin
requested changes
Dec 15, 2021
2 tasks
workgroupengineering
force-pushed
the
Bugfix/Issue_1700_V2
branch
from
da38535 to
25fb4fc
Compare
workgroupengineering
force-pushed
the
Bugfix/Issue_1700_V2
branch
4 times, most recently
from
9c974db to
230d6df
Compare
Assembly-level configuration attributes must have a lower priority than class to allow overriding their behavior.
workgroupengineering
force-pushed
the
Bugfix/Issue_1700_V2
branch
from
230d6df to
bf0aacf
Compare
AndreyAkinshin
approved these changes
Feb 16, 2022
Member
|
@workgroupengineering thanks! |
mawosoft
reviewed
Feb 16, 2022
Comment on lines
-32
to
+33
| private readonly List<BenchmarkLogicalGroupRule> logicalGroupRules = new List<BenchmarkLogicalGroupRule>(); | ||
| private readonly HashSet<BenchmarkLogicalGroupRule> logicalGroupRules = new HashSet<BenchmarkLogicalGroupRule>(); | ||
| private readonly static Conclusion[] emptyConclusion = Array.Empty<Conclusion>(); |
Contributor
There was a problem hiding this comment.
@AndreyAkinshin @workgroupengineering
Not sure if you noticed, but this turns logicalGroupRules back into HashSet<> (changed to List<> in #1866).
(I didn't do a full review, but this one jumped at me)
Member
YegorStepanov
added a commit
to YegorStepanov/BenchmarkDotNet
that referenced
this pull request
Oct 17, 2022
…otnet#1796)" This reverts commit c1f210c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1700
alternative version of PR #1702