Haiku: Fix native component build by trungnt2910 · Pull Request #126701 · dotnet/runtime

trungnt2910 · 2026-04-09T11:50:28Z

This contains the missing configuration updates required to build the native component for Haiku with the latest .NET source.

Part of #55803.

This contains the missing configuration updates required to build the native component for Haiku with the latest .NET source.

dotnet-policy-service · 2026-04-09T11:51:40Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Updates native build configuration to improve compatibility with Haiku when building dotnet/runtime native components, primarily by feature-detecting pthread robust-mutex APIs and adjusting Haiku linker behavior in CMake.

Changes:

Add CMake feature checks for pthread_mutex_consistent and pthread_mutexattr_setrobust, and expose them via pal_config.h.
Conditionally compile robust-mutex initialization and recovery paths in pal_crossprocessmutex.c based on those feature macros.
Adjust Haiku CMake linker-group settings as a workaround for missing upstream CMake support.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/native/libs/System.Native/pal_crossprocessmutex.c	Guard robust mutex attr usage and `EOWNERDEAD` recovery logic behind feature macros.
src/native/libs/configure.cmake	Add configure-time detection for robust-mutex related pthread APIs.
src/native/libs/Common/pal_config.h.in	Export new `HAVE_PTHREAD_MUTEX_*` feature macros to native builds.
eng/native/configurecompiler.cmake	Set Haiku linker-group rescan settings and adjust Haiku linker flags.

src/native/libs/System.Native/pal_crossprocessmutex.c

Instead of guarding for robust mutexes in `pal_crossprocessmutex.c`, guard them in the `CMakeLists.txt` so that platforms without these can fall back to the stubbed implementation on unsupported platforms.

src/native/libs/System.Native/CMakeLists.txt

- Remove the hard-coded OS support list for `pthread` robust mutexes in favor of the new configure-time detection flags `HAVE_PTHREAD_MUTEXATTR_SETROBUST` and `HAVE_PTHREAD_MUTEX_CONSISTENT`. - Simplify the condition by flipping the order.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot · 2026-04-14T09:01:32Z

eng/native/configurecompiler.cmake

+  set(CMAKE_LINK_GROUP_USING_RESCAN_SUPPORTED TRUE)
  add_compile_options($<$<COMPILE_LANGUAGE:ASM>:-Wa,--noexecstack>)
-  add_linker_flag("-Wl,--no-undefined")
+  add_linker_flag("-Wl,--build-id=sha1")


The Haiku-specific linker flags no longer include a “no undefined symbols” check (previously -Wl,--no-undefined). Dropping this makes it easier for undefined references to slip through link and fail later at runtime. If Haiku’s linker doesn’t support --no-undefined, consider using check_linker_flag() and conditionally adding it (or an equivalent like -Wl,-z,defs), so we keep the safety check when it’s supported.

Suggested change

add_linker_flag("-Wl,--build-id=sha1")

add_linker_flag("-Wl,--build-id=sha1")

check_linker_flag(C "-Wl,--no-undefined" LINKER_SUPPORTS_NO_UNDEFINED_FLAG)

if(LINKER_SUPPORTS_NO_UNDEFINED_FLAG)

add_linker_flag("-Wl,--no-undefined")

else()

check_linker_flag(C "-Wl,-z,defs" LINKER_SUPPORTS_Z_DEFS_FLAG)

if(LINKER_SUPPORTS_Z_DEFS_FLAG)

add_linker_flag("-Wl,-z,defs")

endif()

endif()

Copilot · 2026-04-14T09:01:33Z

src/native/libs/System.Native/CMakeLists.txt

+if (HAVE_PTHREAD_MUTEXATTR_SETROBUST AND HAVE_PTHREAD_MUTEX_CONSISTENT)
    list (APPEND NATIVE_SOURCES
-        pal_crossprocessmutex_unsupported.c)
+        pal_crossprocessmutex.c)
 else()
    list (APPEND NATIVE_SOURCES
-        pal_crossprocessmutex.c
-    )
+        pal_crossprocessmutex_unsupported.c)
 endif()


This changes cross-process mutex source selection from an OS allow/deny list to pure symbol detection. That means targets that were previously forced to use pal_crossprocessmutex_unsupported.c (notably Android/OpenBSD/Apple/etc.) may now build the pthread-based implementation if those symbols happen to be present, which is a behavior change and could reintroduce known platform issues. Consider keeping the explicit target exclusions (at least for the previously-denied targets) and combining them with the new HAVE_PTHREAD_MUTEX* feature checks, or add a comment explaining why the old exclusions are no longer needed.

jkotas

@jkoritzinsky Could you please sign off as well?

Haiku: Fix native component build

6ebcf46

This contains the missing configuration updates required to build the native component for Haiku with the latest .NET source.

Copilot AI review requested due to automatic review settings April 9, 2026 11:50

github-actions bot added the area-Infrastructure label Apr 9, 2026

github-project-automation bot added this to Runtime Infra Apr 9, 2026

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 9, 2026

Copilot started reviewing on behalf of trungnt2910 April 9, 2026 11:51 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

src/native/libs/System.Native/pal_crossprocessmutex.c Show resolved Hide resolved

trungnt2910 mentioned this pull request Apr 9, 2026

Haiku: Initial managed libraries support #121880

Merged

jkotas reviewed Apr 9, 2026

View reviewed changes

src/native/libs/System.Native/pal_crossprocessmutex.c Outdated Show resolved Hide resolved

jkotas added the os-haiku label Apr 9, 2026

Copilot AI mentioned this pull request Apr 11, 2026

Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command #126789

Open

1 task

trungnt2910 mentioned this pull request Apr 12, 2026

Haiku: add platform support #55803

Open

jkotas requested changes Apr 12, 2026

View reviewed changes

trungnt2910 requested a review from jkotas April 13, 2026 11:22

trungnt2910 force-pushed the dev/trungnt2910/haiku-native-libs-build branch from 30de881 to c66034d Compare April 13, 2026 11:24

Haiku: Fall back to unsupported mutex C file

544eeec

Instead of guarding for robust mutexes in `pal_crossprocessmutex.c`, guard them in the `CMakeLists.txt` so that platforms without these can fall back to the stubbed implementation on unsupported platforms.

trungnt2910 force-pushed the dev/trungnt2910/haiku-native-libs-build branch from c66034d to 544eeec Compare April 13, 2026 11:26

This was referenced Apr 13, 2026

browser-wasm linux Release LibraryTests queues timing out #117974

Open

System.Net.NameResolution.Tests DNS failures: Name or service not known #126641

Open

jkotas reviewed Apr 13, 2026

View reviewed changes

src/native/libs/System.Native/CMakeLists.txt Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings April 14, 2026 08:56

Copilot started reviewing on behalf of trungnt2910 April 14, 2026 08:57 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

jkotas requested a review from jkoritzinsky April 14, 2026 13:33

jkotas approved these changes Apr 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Haiku: Fix native component build#126701

Haiku: Fix native component build#126701
trungnt2910 wants to merge 3 commits intodotnet:mainfrom
trungnt2910:dev/trungnt2910/haiku-native-libs-build

trungnt2910 commented Apr 9, 2026

Uh oh!

dotnet-policy-service bot commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

jkotas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-  add_linker_flag("-Wl,--build-id=sha1")
+  add_linker_flag("-Wl,--build-id=sha1")
+  check_linker_flag(C "-Wl,--no-undefined" LINKER_SUPPORTS_NO_UNDEFINED_FLAG)
+  if(LINKER_SUPPORTS_NO_UNDEFINED_FLAG)
+    add_linker_flag("-Wl,--no-undefined")
+  else()
+    check_linker_flag(C "-Wl,-z,defs" LINKER_SUPPORTS_Z_DEFS_FLAG)
+    if(LINKER_SUPPORTS_Z_DEFS_FLAG)
+      add_linker_flag("-Wl,-z,defs")
+    endif()
+  endif()

Conversation

trungnt2910 commented Apr 9, 2026

Uh oh!

dotnet-policy-service bot commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants