Skip to content

Haiku: Fix native component build #126701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trungnt2910 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Haiku: Fix native component build #126701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ebcf46
Haiku: Fix native component build
trungnt2910 Apr 9, 2026
544eeec
Haiku: Fall back to unsupported mutex C file
trungnt2910 Apr 13, 2026
e9259d0
Haiku: Simplify robust mutex detection condition
trungnt2910 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/native/configurecompiler.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,12 @@ elseif(CLR_CMAKE_HOST_APPLE)
endif()
endif()
elseif(CLR_CMAKE_HOST_HAIKU)
# Workaround until https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11915 gets merged.
# Haiku uses the GNU toolchain so this should work.
set(CMAKE_LINK_GROUP_USING_RESCAN "LINKER:--start-group" "LINKER:--end-group")
set(CMAKE_LINK_GROUP_USING_RESCAN_SUPPORTED TRUE)
Comment on lines +353 to +356
Copy link
Copy Markdown
Contributor Author

@trungnt2910 trungnt2910 Apr 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake#11919 has just been merged and will be released for 4.4.0.

What should I do about this?
Should I:

  1. Remove this and ensure that whoever's building for Haiku gets CMake 4.4.0+, or
  2. Guard this with if (CMAKE_VERSION VERSION_LESS 4.4), or
  3. Do nothing?

add_compile_options($<$<COMPILE_LANGUAGE:ASM>:-Wa,--noexecstack>)
add_linker_flag("-Wl,--no-undefined")
add_linker_flag("-Wl,--build-id=sha1")
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Haiku-specific linker flags no longer include a “no undefined symbols” check (previously -Wl,--no-undefined). Dropping this makes it easier for undefined references to slip through link and fail later at runtime. If Haiku’s linker doesn’t support --no-undefined, consider using check_linker_flag() and conditionally adding it (or an equivalent like -Wl,-z,defs), so we keep the safety check when it’s supported.

Suggested change
add_linker_flag("-Wl,--build-id=sha1")
add_linker_flag("-Wl,--build-id=sha1")
check_linker_flag(C "-Wl,--no-undefined" LINKER_SUPPORTS_NO_UNDEFINED_FLAG)
if(LINKER_SUPPORTS_NO_UNDEFINED_FLAG)
add_linker_flag("-Wl,--no-undefined")
else()
check_linker_flag(C "-Wl,-z,defs" LINKER_SUPPORTS_Z_DEFS_FLAG)
if(LINKER_SUPPORTS_Z_DEFS_FLAG)
add_linker_flag("-Wl,-z,defs")
endif()
endif()

Copilot uses AI. Check for mistakes.
endif()

#------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions src/native/libs/Common/pal_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@
#cmakedefine01 HAVE_CLOCK_GETTIME_NSEC_NP
#cmakedefine01 HAVE_PTHREAD_CONDATTR_SETCLOCK
#cmakedefine01 HAVE_PTHREAD_MUTEX_CLOCKLOCK
#cmakedefine01 HAVE_PTHREAD_MUTEX_CONSISTENT
#cmakedefine01 HAVE_PTHREAD_MUTEXATTR_SETROBUST
#cmakedefine01 HAVE_TCP_H_TCPSTATE_ENUM
#cmakedefine01 HAVE_TCP_FSM_H
#cmakedefine01 HAVE_GSSFW_HEADERS
Expand Down
7 changes: 3 additions & 4 deletions src/native/libs/System.Native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,12 @@ else() # WASI
)
endif()

if (CLR_CMAKE_TARGET_APPLE OR CLR_CMAKE_TARGET_ANDROID OR CLR_CMAKE_TARGET_BROWSER OR CLR_CMAKE_TARGET_WASI OR CLR_CMAKE_TARGET_OPENBSD)
if (HAVE_PTHREAD_MUTEXATTR_SETROBUST AND HAVE_PTHREAD_MUTEX_CONSISTENT)
list (APPEND NATIVE_SOURCES
pal_crossprocessmutex_unsupported.c)
pal_crossprocessmutex.c)
else()
list (APPEND NATIVE_SOURCES
pal_crossprocessmutex.c
)
pal_crossprocessmutex_unsupported.c)
endif()
Comment on lines +59 to 65
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes cross-process mutex source selection from an OS allow/deny list to pure symbol detection. That means targets that were previously forced to use pal_crossprocessmutex_unsupported.c (notably Android/OpenBSD/Apple/etc.) may now build the pthread-based implementation if those symbols happen to be present, which is a behavior change and could reintroduce known platform issues. Consider keeping the explicit target exclusions (at least for the previously-denied targets) and combining them with the new HAVE_PTHREAD_MUTEX* feature checks, or add a comment explaining why the old exclusions are no longer needed.

Copilot uses AI. Check for mistakes.

if (CLR_CMAKE_TARGET_APPLE)
Expand Down
2 changes: 2 additions & 0 deletions src/native/libs/configure.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ endif()
if (NOT CLR_CMAKE_TARGET_WASI)
check_library_exists(${PTHREAD_LIBRARY} pthread_condattr_setclock "" HAVE_PTHREAD_CONDATTR_SETCLOCK)
check_library_exists(${PTHREAD_LIBRARY} pthread_mutex_clocklock "" HAVE_PTHREAD_MUTEX_CLOCKLOCK)
check_library_exists(${PTHREAD_LIBRARY} pthread_mutex_consistent "" HAVE_PTHREAD_MUTEX_CONSISTENT)
check_library_exists(${PTHREAD_LIBRARY} pthread_mutexattr_setrobust "" HAVE_PTHREAD_MUTEXATTR_SETROBUST)
endif()

check_symbol_exists(
Expand Down
Loading