Skip to content

fix(stage-ui): combobox z-order#980

Merged
nekomeowww merged 3 commits intomoeru-ai:mainfrom
s3d-i:fix/combobox
Jan 21, 2026
Merged

fix(stage-ui): combobox z-order#980
nekomeowww merged 3 commits intomoeru-ai:mainfrom
s3d-i:fix/combobox

Conversation

@s3d-i
Copy link
Contributor

@s3d-i s3d-i commented Jan 21, 2026

Description

ComboboxContent using z-150 while the dialog overlay/content run at z-9999, so the picker was rendered underneath and unclickable.
image

image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @s3d-i, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical UI layering issue where combobox dropdowns were incorrectly rendered beneath modal dialogs, making them inaccessible. The fix involves elevating the z-index of the combobox's portal content to a sufficiently high value, guaranteeing its visibility and interactivity when used in conjunction with other overlaying UI components.

Highlights

  • Z-Index Adjustment: Introduced a new constant COMBOBOX_PORTAL_Z with a high z-index value (z-[12000]) to ensure the combobox content renders above modal overlays.
  • Combobox Content Styling: Replaced the previous z-150 class on the combobox content with the new COMBOBOX_PORTAL_Z constant, resolving the layering issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.

Name Link
🔭 Waiting for approval For maintainers, approve here

Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏

@s3d-i s3d-i changed the title fix: combobox z-order fix(stage-ui): combobox z-order Jan 21, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves the z-order issue for the combobox by introducing a higher z-index value. The change improves maintainability by extracting the z-index into a named constant and provides a clear comment explaining the rationale.

s3d-i and others added 2 commits January 21, 2026 18:55
Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
@nekomeowww nekomeowww merged commit 4790519 into moeru-ai:main Jan 21, 2026
9 checks passed
Joker-of-Gotham pushed a commit to Joker-of-Gotham/airi that referenced this pull request Jan 29, 2026
---------

Co-authored-by: Neko <neko@ayaka.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants