fix(stage-ui): combobox z-order#980
Conversation
Summary of ChangesHello @s3d-i, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical UI layering issue where combobox dropdowns were incorrectly rendered beneath modal dialogs, making them inaccessible. The fix involves elevating the z-index of the combobox's portal content to a sufficiently high value, guaranteeing its visibility and interactivity when used in conjunction with other overlaying UI components. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⏳ Approval required for deploying to Cloudflare Workers (Preview) for stage-web.
Hey, @nekomeowww, @sumimakito, @luoling8192, @LemonNekoGH, kindly take some time to review and approve this deployment when you are available. Thank you! 🙏 |
There was a problem hiding this comment.
Code Review
This pull request effectively resolves the z-order issue for the combobox by introducing a higher z-index value. The change improves maintainability by extracting the z-index into a named constant and provides a clear comment explaining the rationale.
Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
--------- Co-authored-by: Neko <neko@ayaka.moe>
Description
ComboboxContent using z-150 while the dialog overlay/content run at z-9999, so the picker was rendered underneath and unclickable.
