Skip to content

fix(stage-ui): combobox z-order #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nekomeowww merged 3 commits into from
Jan 21, 2026
Merged

fix(stage-ui): combobox z-order #980

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c79c147
fix: combobox z-order
s3d-i Jan 21, 2026
d387657
Apply suggestions from code review
s3d-i Jan 21, 2026
6ac51ae
Apply suggestion from @nekomeowww
s3d-i Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ui/src/components/form/combobox/combobox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ function toDisplayValue(value: T): string {
const option = props.options.flatMap(group => group.children).find(option => option?.value === value)
return option ? option.label : props.placeholder || ''
}

// Keep popover above modal overlays (dialogs use z-9999)
const COMBOBOX_PORTAL_Z = 'z-[12000]'
</script>

<template>
Expand Down Expand Up @@ -71,7 +74,8 @@ function toDisplayValue(value: T): string {
:side-offset="4"
:avoid-collisions="true"
:class="[
'z-150 w-full min-w-[160px] overflow-hidden rounded-xl shadow-sm border will-change-[opacity,transform]',
COMBOBOX_PORTAL_Z,
'w-full min-w-[160px] overflow-hidden rounded-xl shadow-sm border will-change-[opacity,transform]',
'data-[side=top]:animate-slideDownAndFade data-[side=right]:animate-slideLeftAndFade data-[side=bottom]:animate-slideUpAndFade data-[side=left]:animate-slideRightAndFade',
'bg-white dark:bg-neutral-900',
'border-neutral-200 dark:border-neutral-800 border-solid border-2 focus:border-neutral-300 dark:focus:border-neutral-600',
Expand Down