doc: clarify real name requirement in CONTRIBUTING.md#1250
Closed
silverwind wants to merge 1 commit intonodejs:v1.xfrom
Closed
doc: clarify real name requirement in CONTRIBUTING.md#1250silverwind wants to merge 1 commit intonodejs:v1.xfrom
silverwind wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Contributor
|
👍 |
Contributor
|
LGTM |
silverwind
added
child_process
silverwind
changed the title
Contributor
Author
|
I think this is a pretty straightforward improvement, going to merge it in right ahead. |
silverwind
added a commit
that referenced
this pull request
Mar 24, 2015
CONTRIBUTING.md didn't make our rule for requiring real names from contributors clear enough. This commit shall clarify that part. Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> PR-URL: #1250
Contributor
Author
|
merged in 4e9bf93 |
Member
|
Actually I'm -1 on this, it's not straight forward, some people prefer to use pseudonyms and there's no reason to force a real name out of these people, this change could be interpreted as policy. See #606 for an example for this. |
Contributor
Author
|
Ah, I was under the impression it was a hard rule as I was requested to change my user.name on my first contribution (#483 (comment)). If this is a remnant from node.js days, I'm all for dropping it. |
Contributor
|
@rvagg should this be reverted? |
Contributor
|
Please. Real names are slippery beasts and I really don't want to use the one that is still my legal name. There is no reason to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully make it more clear that git's
user.nameshould be set to the real name before committing a pull request. I'm open to suggestions of witty placeholder names ;)related: #1246
cc: @MayhemYDG