Revert "doc: clarify real name requirement"#1276
Closed
Fishrock123 wants to merge 0 commit intonodejs:v1.xfrom
Closed
Revert "doc: clarify real name requirement"#1276Fishrock123 wants to merge 0 commit intonodejs:v1.xfrom
Fishrock123 wants to merge 0 commit intonodejs:v1.xfrom
Conversation
Contributor
|
LGTM, sorry for jumping to wrong conclusions! |
Member
|
lgtm, I'd rather leave it vague like this |
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Mar 26, 2015
This reverts commit 4e9bf93. PR-URL: nodejs#1276 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123
force-pushed
the
revert-real-name-req
branch
from
4f5ef28 to
5e609e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4e9bf93.
I'll take the responsibility for signing off on that.
See discussion in #1250 (comment)
R=@rvagg / @silverwind