feat: add modern PyPI publishing workflow with uv#1
Conversation
Signed-off-by: friendsa <github@duanfei.org>
Summary of ChangesHello @shaonianche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Python packaging and build system by introducing a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a pyproject.toml file to modernize the Python packaging setup, which is a great improvement. The new configuration file correctly captures most of the metadata from the old setup.py.
I've added a couple of suggestions to ensure a complete migration:
- Restoring the
zip_safe=Falsesetting to prevent potential issues with zipped installations. - Migrating the test dependencies to
project.optional-dependenciesto maintain the development and testing workflow.
Additionally, I've noticed the license has been updated to BSD-3-Clause and the project URLs now point to GitHub. These are excellent changes for the project's health and community engagement.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Updated import paths in test_profile.py and test_record.py for consistency. - Refactored test methods in test_record.py to use assert methods instead of plain assertions. - Modified test_sdk_files.py to improve readability and structure. - Updated test_workout_files.py to enhance logging and maintain consistency in test methods. - Refactored test_write_activity_file.py to improve clarity and maintainability. - Updated pyproject.toml to specify dependencies and improve project metadata. - Revised setup.py to align with updated dependencies and project structure.
Refactor test files and update dependencies #1
No description provided.