Skip to content

Add logging for unknown base types#3

Closed
shaonianche wants to merge 1 commit intomainfrom
add-logging-for-unknown-base-types-12499612174913297084
Closed

Add logging for unknown base types#3
shaonianche wants to merge 1 commit intomainfrom
add-logging-for-unknown-base-types-12499612174913297084

Conversation

@shaonianche
Copy link
Copy Markdown
Owner

Replaced the print statement with logger.warning in fit_tool/gen/profile.py to properly log unknown base types.
Corrected the logged variable to type_base_type_name to provide useful information instead of None.
Implemented standard logging pattern using logging.getLogger(__name__).


PR created automatically by Jules for task 12499612174913297084 started by @shaonianche

Replaced `print` statement with `logger.warning` in `fit_tool/gen/profile.py` to properly log unknown base types.
Also corrected the logged variable to `type_base_type_name` to provide useful information instead of `None`.
Used standard `logging.getLogger(__name__)` pattern.

Co-authored-by: shaonianche <16186646+shaonianche@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @shaonianche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling and diagnostic capabilities within fit_tool/gen/profile.py by migrating from a simple print statement to a more robust logging.warning mechanism. The change ensures that instances of unknown base types are reported through the standard logging infrastructure, providing better visibility and control over these events. Furthermore, the logged message now includes the specific name of the unknown type, which significantly improves the utility of the warning for debugging and maintenance.

Highlights

  • Improved Logging: Replaced a direct print statement with logger.warning for handling unknown base types, aligning with standard logging practices.
  • Enhanced Diagnostic Information: Corrected the logged variable to type_base_type_name to provide the actual name of the unknown type, rather than a generic None.
  • Standard Logging Implementation: Initialized a logger instance using logging.getLogger(__name__) for consistent and configurable logging within the module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively improves the logging within fit_tool/gen/profile.py. The changes replace a print statement with a proper logger.warning call, which is a best practice for library and application code. Using logging.getLogger(__name__) correctly creates a module-level logger. Furthermore, the logged message has been corrected to display the type_base_type_name that was not found, providing much more useful diagnostic information than the previous implementation. The use of %-style formatting for the log message is also efficient as it defers string interpolation. The changes are correct, well-implemented, and improve the maintainability of the code.

shaonianche added a commit that referenced this pull request Feb 5, 2026
Refactor test files and update dependencies #1
@shaonianche shaonianche deleted the add-logging-for-unknown-base-types-12499612174913297084 branch February 26, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant