Merged
Conversation
gumb0
commented
Jan 10, 2022
| // new_pages <= memory_pages_limit <= MaxMemoryPagesLimit guarantees memory_pages_to_bytes | ||
| // will not overflow uint32_t. | ||
| assert(new_pages * PageSize <= std::numeric_limits<uint32_t>::max()); | ||
| assert(memory_pages_to_bytes(new_pages) <= std::numeric_limits<uint32_t>::max()); |
Collaborator
Author
There was a problem hiding this comment.
This assertion is fixed in follow-up PRs.
chfast
approved these changes
Jan 10, 2022
gumb0
force-pushed
the
only-memory-size-helper
branch
from
267ddc0 to
20cb1a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 80 81 +1
Lines 12812 12825 +13
=======================================
+ Hits 12687 12700 +13
Misses 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of max-memory-related fixes, fixing an overflow happening on both 32-bit and 64-bit.