Conversation
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 88 88
Lines 13296 13296
=======================================
Hits 13200 13200
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. |
axic
commented
Jun 20, 2022
| wabt::interp::FuncType{{wabt::Type::I32, wabt::Type::I32}, {wabt::Type::I32}}, | ||
| [](wabt::interp::Thread& thread, const wabt::interp::Values& args, | ||
| wabt::interp::Values& results, wabt::interp::Trap::Ptr*) -> wabt::Result { | ||
| wabt::interp::Values& results, wabt::interp::Trap::Ptr*) noexcept -> wabt::Result { |
Member
Author
There was a problem hiding this comment.
Maybe this is not a good ideas as wabt helpers may throw?
Member
Author
There was a problem hiding this comment.
GetCallerInstance() indexes a vector (with local bounds checking), memories(), UnsafeData, ByteSize, and Set seems fine. So I guess it is ok.
chfast
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.