Skip to content

test: Mark env_adler32 noexcept #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axic merged 1 commit into from
Jun 21, 2022
Merged

test: Mark env_adler32 noexcept #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/utils/wabt_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ bool WabtEngine::instantiate(bytes_view wasm_binary)
const auto host_func = wabt::interp::HostFunc::New(m_store,
wabt::interp::FuncType{{wabt::Type::I32, wabt::Type::I32}, {wabt::Type::I32}},
[](wabt::interp::Thread& thread, const wabt::interp::Values& args,
wabt::interp::Values& results, wabt::interp::Trap::Ptr*) -> wabt::Result {
wabt::interp::Values& results, wabt::interp::Trap::Ptr*) noexcept -> wabt::Result {
Copy link
Copy Markdown
Member Author

@axic axic Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is not a good ideas as wabt helpers may throw?

Copy link
Copy Markdown
Collaborator

@chfast chfast Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Do they?

Copy link
Copy Markdown
Member Author

@axic axic Jun 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetCallerInstance() indexes a vector (with local bounds checking), memories(), UnsafeData, ByteSize, and Set seems fine. So I guess it is ok.

assert(args.size() == 2);
const auto offset = args[0].i32_;
const auto length = args[1].i32_;
Expand Down
2 changes: 1 addition & 1 deletion test/utils/wasm3_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Wasm3Engine final : public WasmEngine

namespace
{
const void* env_adler32(IM3Runtime /*runtime*/, uint64_t* stack, void* mem)
const void* env_adler32(IM3Runtime /*runtime*/, uint64_t* stack, void* mem) noexcept
{
const uint32_t offset = static_cast<uint32_t>(stack[0]);
const uint32_t length = static_cast<uint32_t>(stack[1]);
Expand Down