fix(cookies): Update Undici to 5.20 and fix cookies behaviour#6323
Merged
Princesseuh merged 2 commits intomainfrom Feb 21, 2023
Merged
fix(cookies): Update Undici to 5.20 and fix cookies behaviour#6323Princesseuh merged 2 commits intomainfrom
Princesseuh merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7713080 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Princesseuh
commented
Feb 21, 2023
| // them. There are non-standard ways to do it, and node-fetch gives us headers.raw() | ||
| // See https://github.com/whatwg/fetch/issues/973 for discussion | ||
| if (response.headers.has('set-cookie')) { | ||
| if ('raw' in response.headers) { |
Member
Author
There was a problem hiding this comment.
Old left over from node-fetch. When everything is gonna be updated to use getSetCookie, we'll also be able to remove the whole splitCookiesString thing
bluwy
approved these changes
Feb 21, 2023
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
LGTM! Great to be able to remove the old hacks. Looks like this would need a changeset too.
ematipico
approved these changes
Feb 21, 2023
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* fix(cookies): Update Undici to 5.20 and fix cookies behaviour * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
* fix(cookies): Update Undici to 5.20 and fix cookies behaviour * chore: changeset
ematipico
pushed a commit
that referenced
this pull request
Feb 6, 2025
* fix(cookies): Update Undici to 5.20 and fix cookies behaviour * chore: changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Now that Undici released 5.20, we can upgrade again. This fix the
npm auditwarningTesting
Tests will pass!
Docs
N/A