Skip to content

delete description about special non-reserved keywords that might still require special treatment#20458

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
hfxsd:delete-description-about-PLACEMENT-(S)
Jun 4, 2025
Merged

delete description about special non-reserved keywords that might still require special treatment#20458
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
hfxsd:delete-description-about-PLACEMENT-(S)

Conversation

@hfxsd
Copy link
Copy Markdown
Collaborator

@hfxsd hfxsd commented Jun 4, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jun 4, 2025
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Jun 4, 2025
@hfxsd hfxsd requested a review from xhebox June 4, 2025 07:59
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. contribution This PR is from a community contributor. labels Jun 4, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 4, 2025

@xhebox: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Jun 4, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Jun 4, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Jun 4, 2025

/retest

@hfxsd hfxsd closed this Jun 4, 2025
@hfxsd hfxsd reopened this Jun 4, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator Author

hfxsd commented Jun 4, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit feefc1e into pingcap:master Jun 4, 2025
9 of 12 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20461.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 4, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20462.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20463.

@hfxsd hfxsd removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jun 4, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@hfxsd hfxsd added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jun 6, 2025
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20473.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 6, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2025
JaySon-Huang pushed a commit to JaySon-Huang/docs-cn that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants