Add assert to as<int32_t>() for dirty higher bits.#613
Merged
Conversation
axic
commented
Oct 19, 2020
| @@ -264,7 +264,8 @@ TEST(execute_numeric, i32_mul) | |||
|
|
|||
| TEST(execute_numeric, i32_div_s) | |||
Member
Author
There was a problem hiding this comment.
This is especially annoying as we never had a proper 32-bit tests.
axic
force-pushed
the
dirty-stack
branch
2 times, most recently
from
7308462 to
d2a8db1
Compare
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 98.37% 98.36% -0.01%
==========================================
Files 69 69
Lines 9632 9623 -9
==========================================
- Hits 9475 9466 -9
Misses 157 157 |
gumb0
approved these changes
Nov 9, 2020
chfast
approved these changes
Nov 9, 2020
chfast
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #612.